[Components][EventDispatcher] fix ContainerAwareEventDispatcher definition #4240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 16, 2014
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4235 |
| @@ -208,6 +208,8 @@ instance of ``Symfony\Component\HttpKernel\Event\FilterResponseEvent``:: | |||
| .. sidebar:: Registering Event Listeners in the Service Container | |||
|
|
|||
| When you are using the | |||
| :class:`Symfony\\Component\\EventDispatcher\\ContainerAwareEventDispatcher` | |||
| from the | |||
There was a problem hiding this comment.
This is wrong. the ContainerAwareEventDispatcher is not parrt of the DI component
There was a problem hiding this comment.
Indeed, just adding these parts changes the meaning of the sentence.
|
👍 |
|
Thanks @xabbuh! |
weaverryan
added a commit
that referenced
this pull request
Sep 22, 2014
…cher definition (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Components][EventDispatcher] fix ContainerAwareEventDispatcher definition | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4235 Commits ------- 4742859 fix ContainerAwareEventDispatcher definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.